Navigation: Fix TS problems and make TS improvements in demos #32152

dmlvr · 2026-01-09T14:50:07Z

No description provided.

…reme into fix_ts_26_1_3177_rest_react

Copilot

Pull request overview

This pull request fixes TypeScript problems in React demos for VectorMap, FloatingActionButton, and Localization components, enabling the removal of exclusions from tsconfig.react-check.json.

Changes:

Added TypeScript type definitions for VectorMap data modules and improved type safety across VectorMap demos
Enhanced TypeScript types in FloatingActionButton demo with proper ref typing and data structure definitions
Added global TypeScript declarations for Globalize and JSON imports in Localization demo
Changed tooltip functions to return empty objects instead of null for consistency
Added proper ref types and optional chaining for component instance access

Reviewed changes

Copilot reviewed 36 out of 48 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`apps/demos/tsconfig.react-check.json`	Removed exclusions for FloatingActionButton, VectorMap, and Localization demos now that TS issues are fixed
`apps/demos/Demos/VectorMap/**/React/devextreme-vectormap-data.d.ts`	Added type definitions for GeoJSON world map data (multiple files)
`apps/demos/Demos/VectorMap/**/React/data.ts`	Added type definitions for GDP and population data structures
`apps/demos/Demos/VectorMap/**/React/App.tsx`	Improved types with proper casting and optional chaining
`apps/demos/Demos/VectorMap/**/React/TooltipTemplate.tsx`	Added types for tooltip template components (with issues)
`apps/demos/Demos/VectorMap/**/React/PieChartComponent.tsx`	Added proper prop interfaces for PieChart components
`apps/demos/Demos/VectorMap/*/ReactJs/.js`	Applied consistent changes to JavaScript versions (return {}, optional chaining)
`apps/demos/Demos/FloatingActionButton/Overview/React/data.ts`	Added comprehensive type definitions for direction configuration
`apps/demos/Demos/FloatingActionButton/Overview/React/App.tsx`	Added proper ref typing and improved type safety
`apps/demos/Demos/Localization/UsingGlobalize/React/global.d.ts`	Added global type declarations for third-party modules

apps/demos/Demos/FloatingActionButton/Overview/React/App.tsx

apps/demos/Demos/VectorMap/ZoomingAndCentering/React/App.tsx

apps/demos/Demos/VectorMap/TooltipsCustomization/React/TooltipTemplate.tsx

apps/demos/Demos/VectorMap/Overview/React/TooltipTemplate.tsx

apps/demos/Demos/FloatingActionButton/Overview/React/App.tsx

apps/demos/Demos/Localization/UsingGlobalize/React/global.d.ts

apps/demos/Demos/VectorMap/ColorsCustomization/React/App.tsx

Copilot

Pull request overview

Copilot reviewed 36 out of 49 changed files in this pull request and generated 4 comments.

apps/demos/Demos/VectorMap/ZoomingAndCentering/React/App.tsx

apps/demos/Demos/VectorMap/DynamicViewport/React/App.tsx

apps/demos/Demos/VectorMap/TooltipsCustomization/React/TooltipTemplate.tsx

apps/demos/Demos/VectorMap/Overview/React/TooltipTemplate.tsx

pharret31

Some fixes are required

apps/demos/Demos/VectorMap/Overview/React/TooltipTemplate.tsx

Copilot

Pull request overview

Copilot reviewed 36 out of 49 changed files in this pull request and generated 10 comments.

apps/demos/Demos/VectorMap/DynamicViewport/ReactJs/App.js

apps/demos/Demos/VectorMap/ZoomingAndCentering/React/App.tsx

apps/demos/Demos/VectorMap/DynamicViewport/React/App.tsx

apps/demos/Demos/FloatingActionButton/Overview/React/App.tsx

apps/demos/Demos/VectorMap/DynamicViewport/React/App.tsx

apps/demos/Demos/VectorMap/ZoomingAndCentering/ReactJs/App.js

apps/demos/Demos/FloatingActionButton/Overview/ReactJs/App.js

apps/demos/Demos/FloatingActionButton/Overview/React/App.tsx

Copilot

Pull request overview

Copilot reviewed 36 out of 49 changed files in this pull request and generated 4 comments.

apps/demos/Demos/VectorMap/BubbleMarkers/React/App.tsx

apps/demos/Demos/VectorMap/DynamicViewport/React/App.tsx

apps/demos/Demos/FloatingActionButton/Overview/ReactJs/App.js

Copilot

Pull request overview

Copilot reviewed 36 out of 49 changed files in this pull request and generated 3 comments.

apps/demos/Demos/VectorMap/TooltipsCustomization/React/PieChartComponent.tsx

apps/demos/Demos/VectorMap/BubbleMarkers/React/App.tsx

apps/demos/Demos/VectorMap/Legend/React/App.tsx

Copilot

Pull request overview

Copilot reviewed 37 out of 50 changed files in this pull request and generated no new comments.

…ress#32152)

#32174)

dmlvr added 6 commits January 9, 2026 10:38

fix ts in FloatingActionButton

c0be72d

convert-to-js FloatingActionButton

1b21217

fix ts in VectorMap

f0bb392

convert-to-js VectorMap

e81ac25

fix ts in Localization

2e7a9ce

modified tsconfig.react-check.json

058cd43

dmlvr self-assigned this Jan 9, 2026

dmlvr added the 26_1 label Jan 9, 2026

dmlvr and others added 4 commits January 9, 2026 16:56

Merge branch '26_1' into fix_ts_26_1_3177_rest_react

a8886a5

Merge branch '26_1' into fix_ts_26_1_3177_rest_react

88d9dc0

fix imports

c20d00c

Merge branch 'fix_ts_26_1_3177_rest_react' of github.com:dmlvr/DevExt…

9a3ad2d

…reme into fix_ts_26_1_3177_rest_react

dmlvr added the skip-cache label Jan 12, 2026

skip-cache

6123f86

dmlvr marked this pull request as ready for review January 12, 2026 10:08

dmlvr requested a review from a team as a code owner January 12, 2026 10:08

Copilot AI review requested due to automatic review settings January 12, 2026 10:08

Copilot started reviewing on behalf of dmlvr January 12, 2026 10:09 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

fix by copilot review

d1ee8ae

pharret31 reviewed Jan 12, 2026

View reviewed changes

apps/demos/Demos/FloatingActionButton/Overview/React/App.tsx Outdated Show resolved Hide resolved

pharret31 reviewed Jan 12, 2026

View reviewed changes

apps/demos/Demos/Localization/UsingGlobalize/React/global.d.ts Show resolved Hide resolved

pharret31 reviewed Jan 12, 2026

View reviewed changes

apps/demos/Demos/VectorMap/ColorsCustomization/React/App.tsx Outdated Show resolved Hide resolved

pharret31 reviewed Jan 12, 2026

View reviewed changes

apps/demos/Demos/VectorMap/ColorsCustomization/React/App.tsx Outdated Show resolved Hide resolved

fix by review

712c4e0

Copilot AI review requested due to automatic review settings January 12, 2026 12:18

Copilot started reviewing on behalf of dmlvr January 12, 2026 12:18 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

pharret31 reviewed Jan 12, 2026

View reviewed changes

apps/demos/Demos/VectorMap/Overview/React/TooltipTemplate.tsx Show resolved Hide resolved

fix Color Customization

83716ea

dmlvr added 3 commits January 12, 2026 15:33

remove extra useCallBack deps

44357e2

add ReactJs Demo

0dbde1a

fix types

08bb40d

Copilot AI review requested due to automatic review settings January 12, 2026 13:36

Copilot started reviewing on behalf of dmlvr January 12, 2026 13:36 View session

remove extra deps from useCallback

43ae64d

Copilot AI reviewed Jan 12, 2026

View reviewed changes

dmlvr added 2 commits January 12, 2026 16:08

fix by Copilot review

3f9d15a

convert-to-js for FloatingActionButto

529e1f0

Copilot AI review requested due to automatic review settings January 12, 2026 15:13

Merge branch '26_1' into fix_ts_26_1_3177_rest_react

020d7ec

Copilot started reviewing on behalf of dmlvr January 12, 2026 15:14 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

dmlvr added 2 commits January 12, 2026 18:07

fix by copilot review

35feec0

fix some any types

4683bd1

Copilot AI review requested due to automatic review settings January 12, 2026 16:44

Copilot started reviewing on behalf of dmlvr January 12, 2026 16:44 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

apps/demos/Demos/VectorMap/TooltipsCustomization/React/PieChartComponent.tsx Outdated Show resolved Hide resolved

apps/demos/Demos/VectorMap/BubbleMarkers/React/App.tsx Outdated Show resolved Hide resolved

apps/demos/Demos/VectorMap/Legend/React/App.tsx Outdated Show resolved Hide resolved

dmlvr added 2 commits January 12, 2026 19:05

fix by copilot review

b0ed1aa

fix by Copilot review

6f2b88b

Copilot AI review requested due to automatic review settings January 12, 2026 17:10

Copilot started reviewing on behalf of dmlvr January 12, 2026 17:11 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

change type import

d57aa31

pharret31 approved these changes Jan 13, 2026

View reviewed changes

dmlvr merged commit 7cd4b78 into DevExpress:26_1 Jan 13, 2026
96 checks passed

dmlvr added a commit to dmlvr/DevExtreme that referenced this pull request Jan 13, 2026

Navigation: Fix TS problems and make TS improvements in demos (DevExp…

f7fa181

…ress#32152)

dmlvr mentioned this pull request Jan 13, 2026

Navigation: Fix TS problems and make TS improvements in demos (cherry-pick) #32174

Merged

dmlvr added a commit that referenced this pull request Jan 13, 2026

Navigation: Fix TS problems and make TS improvements in demos (#32152) (

cad2d45

#32174)

Navigation: Fix TS problems and make TS improvements in demos #32152

Navigation: Fix TS problems and make TS improvements in demos #32152

Conversation

dmlvr commented Jan 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pharret31 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants